Deleted functions #4691
Merged
Deleted functions #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schedules clean up
schedules clean up
shimonewman
changed the base branch from
refactor-functions-worker
to
feat-db-pools
schedules clean up
app/config/variables.php
Outdated
Comment on lines
923
to
931
| ], | ||
| [ | ||
| 'name' => '_APP_MAINTENANCE_RETENTION_SCHEDULES', | ||
| 'description' => 'Deleted functions schedule cleanup interval (in seconds) ', | ||
| 'introduction' => '1.2.0', | ||
| 'default' => '86400', | ||
| 'required' => false, | ||
| 'question' => '', | ||
| 'filter' => '' |
There was a problem hiding this comment.
Just a formatting thing. Lets add this variable near the other maintenance variables
app/workers/deletes.php
Outdated
Comment on lines
136
to
168
| $sum = $limit = 50; | ||
| $offset = 0; | ||
| /** @var Document[] $functions */ | ||
| while ($sum >= $limit) { | ||
| $schedules = $this->getConsoleDB()->find('schedules', [ | ||
| Query::equal('region', [App::getEnv('_APP_REGION', 'default')]), | ||
| Query::equal('resourceType', ['function']), | ||
| Query::lessThanEqual('resourceUpdatedAt', $datetime), | ||
| Query::equal('active', [false]), | ||
| Query::limit($limit), | ||
| Query::offset($offset), | ||
| ]); | ||
|
|
||
| $sum = \count($schedules); | ||
| $offset = $offset + $limit; | ||
|
|
||
| foreach ($schedules as $schedule) { | ||
| Console::info('Querying schedule for function ' . $schedule->getAttribute('resourceId')); | ||
| $project = $this->getConsoleDB()->getDocument('projects', $schedule->getAttribute('projectId')); | ||
|
|
||
| if ($project->isEmpty()) { | ||
| Console::success('Deleting schedule for function ' . $schedule->getAttribute('resourceId')); | ||
| continue; | ||
| } | ||
|
|
||
| $function = $this->getProjectDB($project)->getDocument('functions', $schedule->getAttribute('resourceId')); | ||
|
|
||
| if ($function->isEmpty()) { | ||
| $this->getConsoleDB()->deleteDocument('schedules', $schedule->getId()); | ||
| Console::success('Deleting schedule for function ' . $schedule->getAttribute('resourceId')); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
There is already a function called deleteByGroup which we can reuse. We don't need to do write the pagination logic again
christyjacob4
requested changes
Nov 16, 2022
schedules clean up
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
schedules clean up
…eat-schedules-deletions
schedules clean up
schedules clean up
…eat-schedules-deletions # Conflicts: # app/config/variables.php
…eat-schedules-deletions
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
…eat-schedules-deletions
schedules clean up
christyjacob4
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted function schedules clean up