Fix the default oauth paths to match the route #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
fix-4714-fix-default-oauth-path
branch
from
ccf8401
to
3a6a9e4
Compare
stnguyen90
commented
Nov 18, 2022
stnguyen90
force-pushed
the
fix-4714-fix-default-oauth-path
branch
from
3a6a9e4
to
c54adfc
Compare
ArmanNik
approved these changes
Nov 23, 2022
stnguyen90
force-pushed
the
fix-4714-fix-default-oauth-path
branch
from
c54adfc
to
c0cd82f
Compare
stnguyen90
force-pushed
the
fix-4714-fix-default-oauth-path
branch
from
c0cd82f
to
0155618
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, Utopia handled
/auth/oauth2/successand/v1/auth/oauth2/successexactly the same (with the same handler). So on mobile, when users were redirected$oauthDefaultSuccess(/v1/auth/oauth2/success), it was still handled. After we deleted that route and moved the code to the new console, the default/v1/auth/oauth2/successresulted in a 404. This changes the default path to remove the/v1/prefix so that the console can handle the redirect.Test Plan
Manual
Related PRs and Issues
Have you added your change to the Changelog?
(The CHANGES.md file tracks all the changes that make it to the
mainbranch. Add your change to this file in the following format)Have you read the Contributing Guidelines on issues?
Yes