Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: db pool sharing #4748

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix: db pool sharing #4748

merged 2 commits into from
Nov 22, 2022

Conversation

Meldiron
Copy link
Contributor

What does this PR do?

Improves connection sharing logic in pools using following vars:

  • _APP_CONNECTIONS_MAX - Maximum amount of connections to a resource (in our case MySQL max connections)
  • _APP_POOL_CLIENTS - Amount of containers to share max connections between
  • _APP_SERVER_MULTIPROCESS - enabled/disabled. Must be enabled if process is using swoole async-style - spawning new process for every worker

Test Plan

No

Related PRs and Issues

x

Have you added your change to the Changelog?

No

Have you read the Contributing Guidelines on issues?

Yes

@christyjacob4 christyjacob4 merged commit 259f868 into feat-db-pools Nov 22, 2022
@stnguyen90 stnguyen90 deleted the fix-db-pool-sharing branch February 14, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants