Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat new usage stats #4770

Merged
merged 100 commits into from
Feb 15, 2023
Merged

Feat new usage stats #4770

merged 100 commits into from
Feb 15, 2023

Conversation

eldadfux
Copy link
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you added your change to the Changelog?

(The CHANGES.md file tracks all the changes that make it to the main branch. Add your change to this file in the following format)

  • One line description of your PR [#pr_number](Link to your PR)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@eldadfux eldadfux changed the base branch from master to feat-db-pools November 23, 2022 17:11
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good, just one confusion regarding the namespace.

app/controllers/shared/api.php Outdated Show resolved Hide resolved
app/worker.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
src/Appwrite/Platform/Tasks/Usage.php Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
app/workers/usage.php Outdated Show resolved Hide resolved
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through everything in brief. The flow looks good to me. I'll review the implementation of listener again in more details.

app/workers/usage.php Outdated Show resolved Hide resolved
app/workers/usage.php Outdated Show resolved Hide resolved
app/executor.php Outdated Show resolved Hide resolved
app/init.php Outdated Show resolved Hide resolved
bin/executor Outdated Show resolved Hide resolved
src/Appwrite/Resque/Worker.php Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@christyjacob4 christyjacob4 merged commit 1832c3c into feat-db-pools Feb 15, 2023
@shimonewman shimonewman deleted the feat-new-usage-stats branch March 9, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants