add internalId to collections #4898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohanidamodar
approved these changes
Dec 26, 2022
| @@ -37,6 +37,7 @@ public function testExport(): void | |||
| $this->assertEquals("_APP_X=value1 | |||
| _APP_Y=value2 | |||
| _APP_Z=value3 | |||
| _APP_W=value5= | |||
There was a problem hiding this comment.
This env variable (_APP_W = value5=) was added lately to the resources/docker/.env
inside the test, there is a check against these values.
I can not see how it will pass without this value being added to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added internalId to collections that have relations and missing internalId column