Update create-team-membership.md #5014
Conversation
|
|
||
| You can only provide one of the User ID, email or phone number to add member to the team. And the priority will be User ID > email and > phone number. | ||
| You only need to provide one of a user ID, email, or phone number. Appwrite will prioritize accepting the user ID > email > phone number if you provide more than one of these parameters. |
There was a problem hiding this comment.
when more than one parameter is provided, we also check to verify it matches, for example if userID and email is provided, then we check if the user with that userID has the same email, and throw exception otherwise. Can we add this info somehow, same for email and phone with priority over email.
There was a problem hiding this comment.
Maybe we don't need this information. I think, practically speaking, it shouldn't make a difference. I think getting an error is enough cause this only happens when they make a mistake.
If we need to document this:
| You only need to provide one of a user ID, email, or phone number. Appwrite will prioritize accepting the user ID > email > phone number if you provide more than one of these parameters. | |
| You only need to provide one of a user ID, email, or phone number. Appwrite will prioritize accepting the user ID > email > phone number if you provide more than one of these parameters. If more than one parameter is provided, Appwrite will verify if the user ID matches the provided email or phone and throw an error otherwise. |
There was a problem hiding this comment.
I'll leave the final decision to @eldadfux ?
There was a problem hiding this comment.
Agree with @gewenyu99. We provide enough information, we can reconsider if we see this becomes a popular error. @gewenyu99 might be good to monitor our error stats on Sentry as part of our DX workflows, and try to detect problematic places in the dev-journey.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you added your change to the Changelog?
(The CHANGES.md file tracks all the changes that make it to the
mainbranch. Add your change to this file in the following format)Have you read the Contributing Guidelines on issues?
(Write your answer here.)