Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migration for 1.3.x #5356

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix: migration for 1.3.x #5356

merged 3 commits into from
Apr 12, 2023

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Apr 12, 2023 •
edited
Loading

What does this PR do?

  • the migration method to fix every document wasn't properly returning the updated document and was therefore not updated

Test Plan

  • manual

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

stnguyen90
stnguyen90 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed migration ran successfully:

image

I can log in and create attributes:

image

@TorstenDittmann TorstenDittmann merged commit 7cec672 into master Apr 12, 2023
@TorstenDittmann TorstenDittmann deleted the fix-migration-v18 branch April 12, 2023 16:27
@stnguyen90 stnguyen90 linked an issue Apr 12, 2023 that may be closed by this pull request
🐛 Bug Report: 500 internal error when clicking on a database collection in Appwrite Web ui #5354
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: 500 internal error when clicking on a database collection in Appwrite Web ui
2 participants
@TorstenDittmann @stnguyen90