Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generic OIDC OAuth2 provider #5449

Merged
merged 1 commit into from Jul 20, 2023
Merged

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Apr 28, 2023

What does this PR do?

This adds a generic OIDC OAuth2 provider that can be used with any OIDC-compatible OAuth2 provider.

Test Plan

  1. Set up an OIDC Client with some provider (Auth0, Okta, etc.)
  2. Fill in the client id, client secret, and well-known endpoint
  3. Create an OAuth2 session

New session:

image

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 force-pushed the feat-4299-oidc-oauth2-provider branch from 0f14df6 to ec2794e Compare April 28, 2023 02:14
@stnguyen90 stnguyen90 force-pushed the feat-4299-oidc-oauth2-provider branch 2 times, most recently from 2274050 to 29f37d1 Compare April 28, 2023 02:28
@stnguyen90 stnguyen90 force-pushed the feat-4299-oidc-oauth2-provider branch from 29f37d1 to 518a37d Compare April 28, 2023 02:48
@loickal
Copy link

loickal commented Apr 28, 2023

Tested it out, works perfectly fine with my Zitadel OpenID Provider.
Different combinationn of either with or without the Well-known Link also work.

Good work!

@TheEaterr
Copy link

I tested it and it worked perfectly with authelia as an OIDC provider

@FiredHydra
Copy link

Tested this with 21.0.0 version of Keycloak and it worked.

@stnguyen90 stnguyen90 added this to the 1.4.0 milestone Jul 20, 2023
@eldadfux eldadfux merged commit 7a02a16 into master Jul 20, 2023
5 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-4299-oidc-oauth2-provider branch September 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants