Fix domains migration #6076
Merged
Fix domains migration #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach tried to migrate the 'rules' collection, but that didn't work because the data was in the 'domains' collection. Since the 'domains' collection was removed, the migration is now done when migrating the 'projects' collection by fetching the domains and then creating the rule documents.
stnguyen90
force-pushed
the
fix-domains-migration
branch
from
7ad4591
to
bd89fd4
Compare
abnegate
approved these changes
Aug 30, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous approach tried to migrate the 'rules' collection, but that didn't work because the data was in the 'domains' collection.
Since the 'domains' collection was removed, the migration is now done when migrating the 'projects' collection by fetching the domains and then creating the rule documents.
Test Plan
Manual:
Migration
Console after MIgration
Related PRs and Issues
None
Checklist