Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration script to not remove schedule from functions #6095

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Aug 31, 2023

What does this PR do?

The schedule attribute was not removed from the functions collection so we shouldn't delete it.

Test Plan

Running migration after upgrading from 1.3.8:

image

functions table:

image

Migrating after running 1.4.0 migration:

image

functions table:

image

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 marked this pull request as ready for review August 31, 2023 16:01
@@ -343,6 +342,7 @@ private function migrateCollections(): void
'providerSilentMode',
'logging',
'deploymentInternalId',
'schedule',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we make sure to include it in the collections.php file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, it's already in there:

[
'$id' => ID::custom('schedule'),
'type' => Database::VAR_STRING,
'format' => '',
'size' => 128,
'signed' => true,
'required' => false,
'default' => null,
'array' => false,
'filters' => [],
],

@abnegate abnegate merged commit 1dc2c08 into 1.4.x Sep 1, 2023
3 checks passed
@stnguyen90 stnguyen90 linked an issue Sep 5, 2023 that may be closed by this pull request
2 tasks
@stnguyen90 stnguyen90 deleted the fix-function-schedule-migration branch September 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Invalid document structure: Unknown attribute: "schedule"
3 participants