Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Global variables #6150

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Fix: Global variables #6150

merged 6 commits into from
Sep 6, 2023

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Sep 5, 2023

What does this PR do?

Global variables didn't work due to missing subquery. Now they should.

This includes change to migration, so after release, devs needs to re-run migration

Test Plan

  • Manual QA

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 linked an issue Sep 5, 2023 that may be closed by this pull request
2 tasks
app/controllers/api/project.php Outdated Show resolved Hide resolved
@christyjacob4 christyjacob4 merged commit 4ea0541 into 1.4.x Sep 6, 2023
2 of 3 checks passed
@abnegate abnegate deleted the fix-global-vars branch October 25, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Project Global Variables Don't Work in Functions
3 participants