Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guests missing global scope #6172

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix guests missing global scope #6172

merged 1 commit into from
Sep 7, 2023

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Sep 7, 2023

What does this PR do?

Add missing global scope to guests

Test Plan

Existing tests

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@christyjacob4 christyjacob4 merged commit ccb7924 into 1.4.x Sep 7, 2023
3 checks passed
@stnguyen90 stnguyen90 deleted the fix-guests-missing-global branch September 7, 2023 17:11
@stnguyen90 stnguyen90 added this to the 1.4.2 milestone Sep 7, 2023
This was referenced Oct 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.4 release
Status: Done
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abnegate @Meldiron @christyjacob4 @stnguyen90