Update GETTING_STARTED.md #6826

GuptaPratik02 · 2023-10-06T12:56:30Z

Improved the doc.
Fixed the issue mentioned in sdk-for-python repository Issue-62.

As mentioned in issue, updated the Getting_Started Guide with necessary changes.
Kindly review and merge the same.
Thank you.

My Discord ID : pratikgupta9997

Fixed the issue mentioned in sdk-for-python repository Issue - 62. Issue link - appwrite/sdk-for-python#62

Haimantika

LGTM

gewenyu99 · 2023-10-10T19:46:03Z

docs/sdks/python/GETTING_STARTED.md

@@ -23,7 +23,7 @@ Once your SDK object is set, create any of the Appwrite service objects and choo
 ```python
 users = Users(client)

-result = users.create('[USER_ID]', 'email@example.com', 'password')
+result = users.create(ID.unique(), email = 'email1@example.com', phone = '+123456789', password = 'password', name = 'user1')


Why email1?

Actually, that I used for demonstrating an example above.
So shall I rename it to email or it's fine?

gewenyu99 · 2023-10-10T19:46:42Z

docs/sdks/python/GETTING_STARTED.md

@@ -43,7 +43,7 @@ client = Client()

 users = Users(client)

-result = users.create(ID.unique(), 'email@example.com', 'password')
+result = users.create(ID.unique(), email = 'email1@example.com', phone = '+123456789', password = 'password', name = 'user1')


Why don't we use something like Walter O'Brien that's actually a name instead of user1

Yeah, that's good idea. Can use Walter O'Brien as name instead of user1, look more fancy and real.
Will make the changes and do a commit again.

Hi @gewenyu99, committed the changes. Checkout once
Thank you.

Changed user1 name and (email1 -> email).

GuptaPratik02 · 2023-10-12T10:37:48Z

Hi @stnguyen90, the reviewers have approved the changes I made.
Kindly checkout the same.

gewenyu99 · 2023-10-12T15:00:13Z

@GuptaPratik02 Please wait for this to be merged by a team member :)

GuptaPratik02 · 2023-10-19T16:11:16Z

Hi @Haimantika,
As you said in Discord chat, should drop our Discord ID in PR.
My Discord ID - pratikgupta9997

christyjacob4 · 2023-10-23T19:44:00Z

docs/sdks/android/GETTING_STARTED.md

-    "email@example.com", 
-    "password"
+    "email@example.com",
+    "+123456789",


This method does not take a phone number

christyjacob4 · 2023-10-23T19:44:04Z

docs/sdks/android/GETTING_STARTED.md

-    "email@example.com", 
-    "password"
+    "email@example.com",
+    "+123456789",


This method does not take a phone number

christyjacob4 · 2023-10-23T19:51:20Z

docs/sdks/android/GETTING_STARTED.md

@@ -82,7 +86,7 @@ The Appwrite Android SDK raises an `AppwriteException` object with `message`, `c

 ```kotlin
 try {
-    var user = account.create(ID.unique(), "email@example.com", "password")
+    var user = account.create(ID.unique(),"email@example.com","+123456789","password","Walter O'Brien")


christyjacob4 · 2023-10-23T19:51:26Z

docs/sdks/apple/GETTING_STARTED.md

-        password: "password"
+        userId: ID.unique(),
+        email: "email@example.com",
+        phone: "+123456789",


christyjacob4 · 2023-10-23T19:51:32Z

docs/sdks/apple/GETTING_STARTED.md

-            password: "password"
+            userId: ID.unique(),
+            email: "email@example.com",
+            phone: "+123456789",


christyjacob4

Please fix the PR. The Account.create() function does not accept a phone number

gewenyu99 · 2023-10-23T20:04:57Z

Please fix the PR. The Account.create() function does not accept a phone number

Does it not? 👀 Huuuuhhhhhh

removed phone number from account.create() function as it does not accept it.

Removed phone number from account.create() function as it does not accept it.

GuptaPratik02 · 2023-10-24T03:45:44Z

Please fix the PR. The Account.create() function does not accept a phone number

Hi @christyjacob4, I rectified the account.create() functions as said, please review the same :)

GuptaPratik02 · 2023-10-28T18:03:07Z

Please fix the PR. The Account.create() function does not accept a phone number

Hi @christyjacob4, I rectified the account.create() functions as said, please review the same :)

Hi @christyjacob4, I made the changes 5-6 days back earlier as said.
Kindly have a look.

My Discord ID - pratikgupta9997

GuptaPratik02 · 2024-02-20T15:44:30Z

Hi @gewenyu99, do I need to make any changes as of now?
I am not able to see the comment you posted just recently.

gewenyu99 · 2024-02-20T16:42:17Z

Hi @gewenyu99, do I need to make any changes as of now? I am not able to see the comment you posted just recently.

Nope, I pinged Christy to see what else he wanted. I think we can merge this.

Approved by Vincent

gewenyu99 · 2024-04-08T20:21:24Z

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

GuptaPratik02 · 2024-04-09T03:42:02Z

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Hey, thanks for the update and my PR has been merged 👍
Here is my Discord ID : pratikgupta9997

GuptaPratik02 · 2024-04-18T16:51:49Z

Hi Vincent, My PR got merged earlier and I had put the comment of my Discord username on my Github repo 9-10 days ago, but I didn't receive any official DM from appwrite yet. Just for confirmation again, I am putting my discord username here as well. *My Discord username* - pratikgupta9997 Hoping to get updates soon.

…

On Tue, Apr 9, 2024 at 1:51 AM Vincent (Wen Yu) Ge ***@***.***> wrote: Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. — Reply to this email directly, view it on GitHub <#6826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVYUT2EHSPSGFYGLOAOGYJDY4L35XAVCNFSM6AAAAAA5VZDAYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGU3TSNZXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Update GETTING_STARTED.md

93fa749

Fixed the issue mentioned in sdk-for-python repository Issue - 62. Issue link - appwrite/sdk-for-python#62

GuptaPratik02 mentioned this pull request Oct 6, 2023

📚 Documentation: Mistake in code snippets in getting started guide appwrite/sdk-for-python#62

Closed

2 tasks

stnguyen90 assigned gewenyu99 and Haimantika Oct 9, 2023

stnguyen90 requested review from gewenyu99 and Haimantika October 9, 2023 17:03

stnguyen90 unassigned gewenyu99 and Haimantika Oct 9, 2023

Haimantika reviewed Oct 10, 2023

View reviewed changes

Haimantika approved these changes Oct 10, 2023

View reviewed changes

gewenyu99 requested changes Oct 10, 2023

View reviewed changes

Update GETTING_STARTED.md

9ccaa5a

Changed user1 name and (email1 -> email).

GuptaPratik02 requested a review from gewenyu99 October 11, 2023 12:46

gewenyu99 approved these changes Oct 11, 2023

View reviewed changes

Merge branch 'main' into doc-sdks-python-update-getting-started-guide

eaba2eb

GuptaPratik02 added 13 commits October 17, 2023 01:07

Update android GETTING_STARTED.md

8cc1c0d

Update apple GETTING_STARTED.md

4be8be1

Update dart GETTING_STARTED.md

777c8dd

Update deno GETTING_STARTED.md

b334f2e

Update dotnet GETTING_STARTED.md

0587aec

Update dart EXAMPLES.md

613a733

Update flutter-dev EXAMPLES.md

2c3b860

Update flutter GETTING_STARTED.md

006d423

Update flutter EXAMPLES.md

0d314df

Update kotlin GETTING_STARTED.md

7d2b450

Update nodejs GETTING_STARTED.md

e93681a

Update php GETTING_STARTED.md

086116d

Update ruby GETTING_STARTED.md

acc408f

Update nodejs GETTING_STARTED.md

c2c6451

GuptaPratik02 requested a review from gewenyu99 October 19, 2023 15:40

gewenyu99 approved these changes Oct 19, 2023

View reviewed changes

gewenyu99 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 19, 2023

christyjacob4 reviewed Oct 23, 2023

View reviewed changes

christyjacob4 previously requested changes Oct 23, 2023

View reviewed changes

GuptaPratik02 added 6 commits October 24, 2023 08:59

Rectified android GETTING_STARTED.md

da504ba

removed phone number from account.create() function as it does not accept it.

Rectified apple GETTING_STARTED.md

9eea574

Removed phone number from account.create() function as it does not accept it.

Rectified flutter-dev EXAMPLES.md

c2ce7d0

Removed phone number from account.create() function as it does not accept it.

Rectified flutter GETTING_STARTED.md

daec743

Removed phone number from account.create() function as it does not accept it.

Rectified flutter EXAMPLES.md

7791cdc

Removed phone number from account.create() function as it does not accept it.

Update web GETTING_STARTED.md

eefbc68

Removed phone number from account.create() function as it does not accept it.

GuptaPratik02 requested a review from christyjacob4 October 24, 2023 03:43

github-actions bot mentioned this pull request Nov 1, 2023

PRs Opened in October 2023 appwrite/.github#93

Closed

Merge branch 'main' into doc-sdks-python-update-getting-started-guide

f287e60

eldadfux merged commit 14e81c2 into appwrite:main Feb 20, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GETTING_STARTED.md #6826

Update GETTING_STARTED.md #6826

GuptaPratik02 commented Oct 6, 2023 •

edited

Haimantika left a comment

gewenyu99 Oct 10, 2023

GuptaPratik02 Oct 11, 2023

gewenyu99 Oct 10, 2023

GuptaPratik02 Oct 11, 2023

GuptaPratik02 Oct 11, 2023

GuptaPratik02 commented Oct 12, 2023

gewenyu99 commented Oct 12, 2023

GuptaPratik02 commented Oct 19, 2023 •

edited

christyjacob4 Oct 23, 2023

christyjacob4 Oct 23, 2023

christyjacob4 Oct 23, 2023

christyjacob4 Oct 23, 2023

christyjacob4 Oct 23, 2023

christyjacob4 left a comment

gewenyu99 commented Oct 23, 2023

GuptaPratik02 commented Oct 24, 2023

GuptaPratik02 commented Oct 28, 2023 •

edited

GuptaPratik02 commented Feb 20, 2024

gewenyu99 commented Feb 20, 2024

gewenyu99 commented Apr 8, 2024

GuptaPratik02 commented Apr 9, 2024

GuptaPratik02 commented Apr 18, 2024 via email

Update GETTING_STARTED.md #6826

Update GETTING_STARTED.md #6826

Conversation

GuptaPratik02 commented Oct 6, 2023 • edited

Haimantika left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuptaPratik02 commented Oct 12, 2023

gewenyu99 commented Oct 12, 2023

GuptaPratik02 commented Oct 19, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christyjacob4 left a comment

Choose a reason for hiding this comment

gewenyu99 commented Oct 23, 2023

GuptaPratik02 commented Oct 24, 2023

GuptaPratik02 commented Oct 28, 2023 • edited

GuptaPratik02 commented Feb 20, 2024

gewenyu99 commented Feb 20, 2024

gewenyu99 commented Apr 8, 2024

GuptaPratik02 commented Apr 9, 2024

GuptaPratik02 commented Apr 18, 2024 via email

GuptaPratik02 commented Oct 6, 2023 •

edited

GuptaPratik02 commented Oct 19, 2023 •

edited

GuptaPratik02 commented Oct 28, 2023 •

edited