Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat upgrade php version (8.0) #713

Merged
merged 140 commits into from
Apr 29, 2021
Merged

Feat upgrade php version (8.0) #713

merged 140 commits into from
Apr 29, 2021

Conversation

eldadfux
Copy link
Member

What does this PR do?

Upgrading PHP version from 7.4 to 8.0. Currently using RC2 version.

Test Plan

Using current tests.

Related PRs and Issues

None.

Have you read the [Contributing Guidelines on issues]

Yes

@eldadfux eldadfux changed the base branch from master to 0.7.x October 27, 2020 16:12
Copy link
Contributor

@SoftCreatR SoftCreatR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a problem, but you are attempting to install docker-cli twice (line 136 & 141 in Dockerfile).

src/Appwrite/Extend/PDOStatement.php Show resolved Hide resolved
@eldadfux
Copy link
Member Author

Not really a problem, but you are attempting to install docker-cli twice (line 136 & 141 in Dockerfile).

Fixed 👌🏻

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are a bit beyond my PHP horizon, but I can't see anything that catches my eye.

@eldadfux
Copy link
Member Author

Thanks for all the help @SoftCreatR and @TorstenDittmann!

I'll wait for the official release before finally merging this PR.

.travis-ci/prepare.sh Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
app/workers/functions.php Outdated Show resolved Hide resolved
app/workers/webhooks.php Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@eldadfux eldadfux merged commit 5aad3f7 into 0.8.x Apr 29, 2021
@eldadfux eldadfux deleted the feat-upgrade-php-version branch May 15, 2021 07:07
@eldadfux eldadfux moved this from In progress to Done in 0.8 May 24, 2021
@TorstenDittmann TorstenDittmann added this to Done in 0.8.x Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.8
  
Done
0.8.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants