Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git installation deletion #7140

Merged
merged 1 commit into from Nov 15, 2023
Merged

Fix git installation deletion #7140

merged 1 commit into from Nov 15, 2023

Conversation

vermakhushboo
Copy link
Member

@vermakhushboo vermakhushboo commented Nov 15, 2023 •
edited by stnguyen90

What does this PR do?

Replace deletes with queueForDeletes

Test Plan

Tested locally

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@abnegate abnegate merged commit 74604a1 into 1.4.x Nov 15, 2023
38 checks passed
@stnguyen90 stnguyen90 linked an issue Nov 15, 2023 that may be closed by this pull request
🐛 Bug Report: Error disconnecting from GitHub #7137
Closed
2 tasks
This was referenced Dec 1, 2023
Closed
Closed
@stnguyen90 stnguyen90 deleted the fix-delete-installation branch April 25, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Error disconnecting from GitHub
2 participants
@vermakhushboo @abnegate