Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Max password length #7376

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Feat: Max password length #7376

merged 1 commit into from
Jan 2, 2024

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Jan 2, 2024

What does this PR do?

Implements 256 chars max password length.

Passwords hashed with Argon2 should be safe no matter the length, but it always make sense to have reasonable limit - for performance, if nothing else.

Test Plan

  • New tests added

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux eldadfux merged commit 31e23a3 into 1.5.x Jan 2, 2024
20 checks passed
@stnguyen90 stnguyen90 deleted the feat-max-password-length branch January 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants