Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update place holders from [PARAM_NAME] to <PARAM_NAME> #7560

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

gewenyu99
Copy link

@gewenyu99 gewenyu99 commented Feb 9, 2024

What does this PR do?

When generating specs, we use x-example to populate examples in the generated code examples.
We used to use the format [PARAM NAME] because we had a specific PHTML restriction on <> type place holders.

Now we can switch to <> type tokens, so these placeholders will not be confused with arrays.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux eldadfux merged commit eb75b52 into main Feb 11, 2024
20 checks passed
@abnegate abnegate deleted the update-x-example-format branch May 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants