Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest Platform and add Core module #7936

Merged
merged 12 commits into from
Jun 9, 2024
Merged

Use latest Platform and add Core module #7936

merged 12 commits into from
Jun 9, 2024

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented Apr 8, 2024 •
edited

What does this PR do?

  • Update platform to latest version that now has module
  • Add and initialize platform with Core module
  • Remove worker index reference in workers (after talking to @abnegate it was stale code)

Test Plan

  • No feature changes, existing tests should suffice

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@lohanidamodar lohanidamodar merged commit 00a6337 into refactor-usage-sn Jun 9, 2024
21 checks passed
@lohanidamodar lohanidamodar deleted the feat-upgrade-platform-with-module branch June 9, 2024 00:55
@lohanidamodar lohanidamodar mentioned this pull request Jun 9, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lohanidamodar @eldadfux @christyjacob4