Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sending realtime stats #8104

Merged
merged 1 commit into from
May 8, 2024
Merged

Disable sending realtime stats #8104

merged 1 commit into from
May 8, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 8, 2024 •
edited
Loading

What does this PR do?

Disable sending realtime stats because the $database->find('realtime') is throwing:

Cannot execute queries while other unbuffered queries are active.

In addition, the realtime stats are not being collected so there's no point in having this enabled.

Test Plan

Manually confirmed realtime still works:

image

Related PRs and Issues

  • None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
fix(realtime): disable sending realtime stats
fa78ae0 
Disable sending realtime stats because the $database->find('realtime')
is throwing:

> Cannot execute queries while other unbuffered queries are active.

In addition, the realtime stats are not being collected so there's no
point in having this enabled.
TorstenDittmann
TorstenDittmann approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have a placeholder on the console during this hotfix?

@stnguyen90
Copy link
Contributor Author

Do we want to have a placeholder on the console during this hotfix?

@TorstenDittmann, sure, we can ask design for something, but no harm in getting this in now because realtime has been reporting 0 since April (#7911)

@stnguyen90 stnguyen90 marked this pull request as ready for review May 8, 2024 22:32
@stnguyen90 stnguyen90 merged commit 6b31f13 into refactor-usage-sn May 8, 2024
21 checks passed
@stnguyen90 stnguyen90 deleted the fix-unreliable-realtime-workaround branch May 8, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stnguyen90 @eldadfux @TorstenDittmann