Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't Override robots.txt for Other Domains #8185

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix: Don't Override robots.txt for Other Domains #8185

merged 2 commits into from
May 24, 2024

Conversation

ItzNotABug
Copy link
Contributor

@ItzNotABug ItzNotABug commented May 23, 2024 •
edited
Loading

What does this PR do?

This PR allows using custom robots.txt on function domains.

Test Plan

Manual -

Robots.txt

Screenshot 2024-05-23 at 2 58 16 PM Screenshot 2024-05-23 at 2 58 22 PM

Humans.txt

Screenshot 2024-05-23 at 3 57 24 PM Screenshot 2024-05-23 at 3 57 29 PM

Related PRs and Issues

N/A

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Meldiron
Meldiron approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 🙌
Not 100% sure about approach, let's wait for 1 more approving review before merging

@christyjacob4 christyjacob4 changed the base branch from main to 1.5.x May 24, 2024 13:15
@christyjacob4 christyjacob4 merged commit e55f0ad into appwrite:1.5.x May 24, 2024
23 checks passed
@ItzNotABug ItzNotABug deleted the fix-robots-txt branch May 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ItzNotABug @Meldiron @christyjacob4