Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat use markdoc docs #15

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Feat use markdoc docs #15

merged 9 commits into from
Jan 9, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Nov 27, 2023 •
edited
Loading

What does this PR do?

  • Use cleaned markdoc/markdown files as data source

Test Plan

See tests/ folder to responses

Have you read the Contributing Guidelines on issues?

Yes

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
TGlide
TGlide approved these changes Dec 21, 2023
View reviewed changes
scripts/web-sources.js Show resolved Hide resolved
eldadfux
eldadfux reviewed Jan 6, 2024
View reviewed changes
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should share a lot more technical details about how the Assistant work in our readme, its not very helpful right now.

@loks0n
Copy link
Member Author

loks0n commented Jan 8, 2024

We should share a lot more technical details about how the Assistant work in our readme, its not very helpful right now.

Added some more detail here

@loks0n loks0n requested a review from eldadfux January 8, 2024 10:44
@loks0n loks0n merged commit 3d7016f into main Jan 9, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TGlide TGlide TGlide approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

@eldadfux eldadfux Awaiting requested review from eldadfux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loks0n @eldadfux @TGlide