Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Refactor: Code Modularisation #6

Open
2 tasks done
Sarthak2601 opened this issue May 16, 2023 · 3 comments
Open
2 tasks done

馃殌 Refactor: Code Modularisation #6

Sarthak2601 opened this issue May 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Sarthak2601
Copy link

Sarthak2601 commented May 16, 2023

馃敄 Feature description

This issue suggests a refactoring effort aimed at improving the codebase by breaking it down into smaller components.

Note: I'm using the issue template for feature requests since there's no template for refactoring and also because this is neither a bug nor a documentation fix.

馃帳 Pitch

By breaking down the code into smaller and more manageable components, we can enhance the readability and maintainability of the codebase. This refactor will not only make the code more approachable for new contributors but also improve the overall understanding and navigation of the project. It will also lead to optimisation since we can reuse these small components at multiple places.

For example: we can break down most of the component files into smaller components. I've created a follow up PR(#7) for the footer component. If it gets approved, we can probably create a common issue that covers file-by-file refactoring of multiple files using a check list.

PS: I'd like to work on this and follow up issue(s).

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@Sarthak2601 Sarthak2601 changed the title 馃殌 Feature: Code Modularisation 馃殌 Refactor: Code Modularisation May 18, 2023
@Sarthak2601
Copy link
Author

Sarthak2601 commented May 18, 2023

Hi @christyjacob4 @loks0n @Meldiron, could you please take a look at this and the follow up PR -- thanks!

@loks0n
Copy link
Member

loks0n commented May 22, 2023

Hey @Sarthak2601 馃憢
Thanks for raising this 馃帀

I've responded to your PR. For the broader issue of code modularisation - this is definitely something that can be improved throughout the codebase, but I don't think the Footer is a good candidate for that.

@joeyouss joeyouss added the enhancement New feature or request label May 26, 2023
@Sarthak2601
Copy link
Author

Thanks for your response @loks0n! Is there any specific part of the codebase that you'd recommend I begin looking into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants