Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code modularisation for footer #7

Conversation

Sarthak2601
Copy link

@Sarthak2601 Sarthak2601 commented May 16, 2023

What does this PR do?

Refactors the footer layout file by breaking it down into smaller reusable components.

Test Plan

I tested these changes on my personal server which i deployed during the initial setup. It works the same as the original implementation. Also deployed to vercel.

Screenshot 2023-05-16 at 22 53 00

Related PRs and Issues

This issue is related to issue #6: Code Modularisation.

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
built-with-appwrite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 10:15pm

@Sarthak2601 Sarthak2601 changed the title code modularisation for footer refactor: code modularisation for footer May 16, 2023
@loks0n
Copy link
Member

loks0n commented May 18, 2023

Hey @Sarthak2601 👋

Regarding #6

Thanks for your contribution! 🎉 After review, we've found that the refactor could overcomplicate our Footer component. We aim to maintain balance between clarity and simplicity in our code.

While we won't be merging this PR, we value your effort and encourage you to keep contributing. Don't be discouraged, your input is always welcome! Let's keep improving together! 💪😊

@Sarthak2601
Copy link
Author

Hey @Sarthak2601 👋

Regarding #6

Thanks for your contribution! 🎉 After review, we've found that the refactor could overcomplicate our Footer component. We aim to maintain balance between clarity and simplicity in our code.

While we won't be merging this PR, we value your effort and encourage you to keep contributing. Don't be discouraged, your input is always welcome! Let's keep improving together! 💪😊

Cool, no problem. I'll close this PR then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants