Feat: Add OPR V2 runtimes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'req' variable has: | ||
| 'headers' - object with request headers | ||
| 'payload' - request body data as a string | ||
| 'env' - object with environment variables |
There was a problem hiding this comment.
Suggested change
| 'env' - object with environment variables | |
| 'variables' - object with environment variables |
We need to rename this to variables.. in all the runtimes :)
There was a problem hiding this comment.
I would love to address that in separate PR when all active PRs are merged. That way I am 100% sure I addressed it everywhere properly - same for class parameters (databaseId) and library versions.
christyjacob4
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
node-18tonode-18.0(IIRC, we never used 18, it was always 18.0)Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes 馃槆