Go templates update

[phaus]

Follow PR of #287

[lohanidamodar]

Looks really promising. Just few concerns.

[abnegate]

Awesome work so far 😁

[phaus]

Hi @christyjacob4! I did react to all suggestions. Is there anything else, I can do?

[lohanidamodar]

Some more small changes.

[lohanidamodar]

One more small request.

Also can you generate and push the generated go sdk in your own separate repository and provide a link want to look at the final code.

[phaus]

@lohanidamodar I did update the go-sdk repo with the latest generate code.
You can find it here: https://github.com/phaus/sdk-for-go

[lohanidamodar]

@phaus Saw the generated code, looks awesome. I have a question
Is something like data objects common in Go or we just expose the JSON we receive from the server?

[phaus]

@lohanidamodar

At the moment a client call returns a map with all elements as key => vallues.
One could migrate that to specific structs to make the API more specific.
For that reason I would need an overview about the fields that are used. Is there a deploment a swagger UI for the provided swagger spec somewhere?

[lohanidamodar]

@phaus I don't remember that we have a swagger UI, however, if you look at our existing SDKs (Dart, Android, Kotlin, Apple, Swiift, all of these have response model implemented). The details of definitions can be found in our spec as well under definitions key. Look at the existing SDKs and please let us know if there's any confusion.

[lohanidamodar]

Also, I would love you to sync this PR with latest master, we have restructured testing to make it more effective, let us know if there's any confusion.

[phaus]

@lohanidamodar I did a rebase to the current upstream master branch.
However, to have valid go code generated, the sdk env GitUserName has to be appwrite.
Since that seems to impact all other tests as well, I need some hints on how to impliment it in a better way.

I will have a look into response struct the next days.

[phaus]

TBH I have actually no idea why the Flutter Test is failing right now

[lohanidamodar]

@phaus Why do you need gitusername to be appwrite, you are not actually pulling from github for test right, you are using the local instance. In the testfile can you can make appwrite to githubuser or something that was perviously there? Modify the test.

[lohanidamodar]

TBH I have actually no idea why the Flutter Test is failing right now

Don't worry about the Flutter test, that has nothing to do with what you did. Fix for that is already pending in my PR #372

[phaus]

I did the rebase, updated my test to the new setup.

[phaus]

deactivate the failing test case. Is there anything else, that is missing in this PR?

[lohanidamodar]

Few more things to take care of before we can proceed. We want to get this right. Let us know if you need any help with chunked and resume-able upload

[lohanidamodar]

Hey, we need a chunked and resume-able upload support here (check dart/web sdk where we have it already implemented)

[phaus]

That is then something I have to implement later on.
Due to time constraints I won't be able to do that right now.
Should I disable the API then for now?

[lohanidamodar]

@phaus no we don't need to disable the API, if it's okay with you, we can proceed with getting this merged and add the chunked upload/resumable upload later by our team or you if you get time. If that's good and some other team member review it, we can proceed forward. We are really happy with the work you have put in and the patience you had with us. Just a little more and we can get this merged 🙏🏻

[lohanidamodar]

@phaus I resolved the conflict, and re-enabled the disabled test. If everything goes well, we will get this merged.

[abnegate]

Looking great! Thanks for all your hard work 🚀