fix: windows CLI is installed in wrong location #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, when installing the CLI using this script, it would move the downloaded CLI executable as a file to `%LOCALAPPDATA%/Appwrite` while it is inteded to move it to `%LOCALAPPDATA%/Appwrite/appwrite.exe`. This commit fixes this problem by creating the directory explicitly and moving the file into it.
|
@TorstenDittmann Can you give this a review ? |
christyjacob4
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Template looks good to me.
I'm not well versed into windows shell, so Im going to let @TorstenDittmann help me there
Awesome work @benjaminSchilling33
|
Thanks @christyjacob4 In the meanwhile this seems to bei redundant to #397 |
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
|
Thanks for the PR 🥳 It will be part of the next release 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when installing the CLI using this script, it would move the downloaded CLI executable
as a file to
%LOCALAPPDATA%/Appwritewhile it is intended to move it to%LOCALAPPDATA%/Appwrite/appwrite.exe.This commit fixes this problem by creating the directory explicitly and moving the file into it.
closes: appwrite/appwrite#3007