Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Support in Python SDK #453

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Async Support in Python SDK #453

wants to merge 17 commits into from

Conversation

ms7m
Copy link

@ms7m ms7m commented May 24, 2022

More information @ #452

@ms7m ms7m mentioned this pull request May 24, 2022
Closed
2 tasks
@TorstenDittmann
Copy link
Contributor

Hey @ms7m, just wanted to let you know that our engineer who is going to review this on leave and is back next week 😉

Awesome work 👏🏻

abnegate
abnegate requested changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Just a few comments

.travis.yml Outdated Show resolved Hide resolved
templates/python/package/aio/exception.py.twig Outdated Show resolved Hide resolved
templates/python/package/aio/input_file.py.twig Outdated Show resolved Hide resolved
templates/python/package/aio/query.py.twig Outdated Show resolved Hide resolved
templates/python/package/aio/service.py.twig Outdated Show resolved Hide resolved
templates/python/package/aio/client.py.twig Outdated Show resolved Hide resolved
templates/python/package/aio/services/service.py.twig Show resolved Hide resolved
@ms7m
Copy link
Author

ms7m commented Jun 15, 2022

Nice work so far! Just a few comments

Thanks, I've been swamped at work and battling a cold -- but I'll get these changes sorted!

@ms7m ms7m requested a review from abnegate June 18, 2022 03:44
@stnguyen90
Copy link
Contributor

@ms7m, sorry, but would you please fix the merge conflict?

@ms7m
Copy link
Author

ms7m commented Oct 15, 2022

@stnguyen90 sure, my branch is quite behind since this kinda fell off my radar.

@stnguyen90 stnguyen90 requested review from stnguyen90 and removed request for abnegate December 27, 2022 17:21
stnguyen90
stnguyen90 requested changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms7m it seems like the tests are failing.

@lohanidamodar
Copy link
Member

@abnegate is this relevant?

@stnguyen90
Copy link
Contributor

@ms7m seems like the tests are still failing. Any ideas why?

@ms7m
Copy link
Author

ms7m commented Feb 8, 2023

@stnguyen90 -- running locally, only a single test is failing. I'll take a crack at this weekend and get this freed up!

@abnegate
Copy link
Contributor

@ms7m Is it possible to have the async methods without adding the AsyncClient? So the async versions of the methods would be together with the sync versions in the existing client?

@stnguyen90 stnguyen90 mentioned this pull request Apr 28, 2023
Open
@stnguyen90 stnguyen90 linked an issue Apr 28, 2023 that may be closed by this pull request
Idea: Make SDK asynchronous. appwrite/sdk-for-python#26
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 requested changes

@abnegate abnegate abnegate requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Make SDK asynchronous.
5 participants
@ms7m @TorstenDittmann @stnguyen90 @lohanidamodar @abnegate