Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure attributes with $ use _ instead in GraphQL examples #597

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

$ is reserved so we had to replace all $ with _

Test Plan

Manually generated examples.

databases/get-document.md:

query {
    databasesGetDocument(
        databaseId: "[DATABASE_ID]",
        collectionId: "[COLLECTION_ID]",
        documentId: "[DOCUMENT_ID]"
    ) {
        _id
        _collectionId
        _databaseId
        _createdAt
        _updatedAt
        _permissions
        data
    }
}

account/get.md:

query {
    accountGet {
        _id
        _createdAt
        _updatedAt
        name
        registration
        status
        passwordUpdate
        email
        phone
        emailVerification
        phoneVerification
        prefs
    }
}

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

$ is reserved so we had to replace all $ with _
@eldadfux eldadfux merged commit a13ad2a into master Dec 27, 2022
@lohanidamodar lohanidamodar deleted the fix-graphql-examples-dollar-sign branch April 6, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants