Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.d.ts): optional parameters should have question mark #64

Merged
merged 1 commit into from
Oct 5, 2020
Merged

fix(index.d.ts): optional parameters should have question mark #64

merged 1 commit into from
Oct 5, 2020

Conversation

benceHornyak
Copy link
Contributor

Method definitions was missing ? from them indicating that they are optional parameter.

Please let me know if there is anything that I missed.

@eldadfux
Copy link
Member

eldadfux commented Oct 5, 2020

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like me to send you some cool Appwrite stickers and magnets! Please note that shipping might take longer times because of COVID19.

As a way of saying thank you, we have just invited you to join the Appwrite organization on GitHub. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

@eldadfux
Copy link
Member

eldadfux commented Oct 5, 2020

I'll release an updated tag and publish it on NPM as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants