Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: property type check for boolean properties #685

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

adityaoberai
Copy link
Member

What does this PR do?

Fixes property type checking for boolean fields in the From() function in Models

Example (from the Locale model):

  • Model (eu is a boolean field)

image

  • Earlier (generated SDK)

image

  • Now (generated SDK)

image

Test Plan

  • Install the dependencies using composer
  • Run php example.php in the repo
  • View the From() function in all Models in the generated .NET SDK

Related PRs and Issues

No

Have you read the Contributing Guidelines on issues?

Yes

@lohanidamodar lohanidamodar merged commit 19f746e into master Jul 4, 2023
1 of 3 checks passed
@lohanidamodar lohanidamodar deleted the fix-dotnet-models-bool-check branch July 5, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants