fix-805-change-GetValues-to-TryGetValues-when-parsing-content-type-header #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityaoberai, would you be able to help review? |
loks0n
approved these changes
Apr 29, 2024
abnegate
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The DotNet SDK has a bug where the SDK throws an InvalidOperationException if the "Content-Type" header is not present in the response from Appwrite. This is the case if you for example delete a document.
This PR changes the code to use
TryGetValueswhich returns a boolean if it could successfully parse the header.Fixes #805
Test Plan
I checked out the repository of the dotnet-sdk, made the proposed changes and tested.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
I read the Contributing Guidelines