Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: esm import extensions #828

Merged
merged 4 commits into from
May 14, 2024
Merged

fix: esm import extensions #828

merged 4 commits into from
May 14, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented May 8, 2024 •
edited by stnguyen90
Loading

@loks0n loks0n requested a review from stnguyen90 May 8, 2024 13:15
@loks0n loks0n changed the title fix: remove bundle=false fix: esm import extensions May 8, 2024
stnguyen90
stnguyen90 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty hacky but at least it works.

image

@TorstenDittmann TorstenDittmann merged commit 27de410 into master May 14, 2024
34 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-fix-esm-bundle branch May 14, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

@loks0n loks0n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loks0n @stnguyen90 @TorstenDittmann