feat(cli): Creating function from all available templates #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor-singular-to-plural
to
feat-create-resources
May 27, 2024 13:20
Meldiron
reviewed
May 27, 2024
| let gitInitCommands = "git clone -b v3 --single-branch --depth 1 --sparse https://github.com/{{ sdk.gitUserName }}/functions-starter ."; // depth prevents fetching older commits reducing the amount fetched | ||
| let gitInitCommands = "git clone --single-branch --depth 1 --sparse https://github.com/{{ sdk.gitUserName }}/templates ."; // depth prevents fetching older commits reducing the amount fetched | ||
|
|
||
| let gitPullCommands = `git sparse-checkout add ${answers.runtime.name}`; |
There was a problem hiding this comment.
I think this doesnt work. From video I see loading templates is slow. Mabe it's because it's cloning everything. Here We need node not node-21.0
There was a problem hiding this comment.
Runtime name is a new field, and it's just node.
There was a problem hiding this comment.
Hmm okie, Ill try to run with timings to see what takes 2-3 seconds
christyjacob4
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Java doesn't have any templates other than the
starterone, so it will be chosen by defaultfunctions-template.mp4