Feat general improvements #874
Conversation
| if (err !== null) { | ||
| console.log('\n'); | ||
| error('Opening in default browser. ' + err) |
There was a problem hiding this comment.
what exactly are we doing here?why are we saying opening in default browser and appending the error?
There was a problem hiding this comment.
When the browser failed to open the link for any reason the error function will preint
Error: Opening in default browser. ERROR MESSAGE
| @@ -269,6 +269,7 @@ const init = new Command("init") | |||
| .option("--organizationId <organizationId>", "{{ spec.title|caseUcfirst }} organization ID") | |||
| .option("--projectId <projectId>", "{{ spec.title|caseUcfirst }} project ID") | |||
| .option("--projectName <projectName>", "{{ spec.title|caseUcfirst }} project ID") | |||
| .option(`-sh, --self-hosted`, `Flag for enabling custom endpoint for self hosted instances for non-logged in users`) | |||
There was a problem hiding this comment.
what are we trying to achieve here?
There was a problem hiding this comment.
In case the user is not logged in, the project init will prompt the user to login,
By default, all logins are targeted at the cloud, this will give the user the option to add an endpoint
There was a problem hiding this comment.
No lets not do this.. There is already a dedicated command for setting endpoint with appwrite client.
We should make sure every command has one job and one job only
Feat collection push improvements
christyjacob4
temporarily deployed
to
cli-testing
GitHub Actions
Inactive
byawitz
changed the base branch from
feat-adding-register
to
feat-arg-project-init
What does this PR do?
--verboseor--report--console --opendidn't workwhoamiCheck cannot destrucutre selfHosted of undefinedbug