Use JSONbig to parse and stringify JSON #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way JavaScript handles numbers, the standard JSON parser will convert the max PHP int, 9223372036854775807, to 9223372036854776000. However, this is problematic because the resulting number is an invalid int in PHP so the integer validation fails. This PR ensures we use JSONbig to parse and stringify JSON in the CLI to retain the precision of the numbers.
byawitz
approved these changes
Jul 10, 2024
Meldiron
approved these changes
Jul 10, 2024
TorstenDittmann
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to the way JavaScript handles numbers, the standard JSON parser will convert the max PHP int, 9223372036854775807, to
9223372036854776000. However, this is problematic because the resulting number is an invalid int in PHP so the integer validation fails.
This PR ensures we use JSONbig to parse and stringify JSON in the CLI to retain the precision of the numbers.
Fixes appwrite/sdk-for-cli#124
Test Plan
Manually pulled and pushed successfully
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes