Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation for Sveltekit tutorial #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ab-smith
Copy link

@ab-smith ab-smith commented Oct 9, 2023

Corrections on Sveltekit documentation

What does this PR do?

Fix step 6 instructions (declared on the store)
Indicates that collections need explicit permission to avoid 401 errors.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

fix step 6 instructions
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 1:46pm

@ab-smith ab-smith changed the title Update +page.markdoc Fix Documentation for Sveltekit tutorial Oct 9, 2023
@@ -33,8 +35,6 @@ import { databases } from "$lib/appwrite";
export const IDEAS_DATABASE_ID = "6508783c5dc784d544dd"; // Replace with your database ID
export const IDEAS_COLLECTION_ID = "65087840ab307cb06883"; // Replace with your collection ID

const databases = new Databases(client);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

@@ -21,6 +21,8 @@ Create a new collection with the following attributes:
| title | String | Yes |
| description | String | No |

Setup permissions on your collection to allow all users for now. In case you get 401 error, check this step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pick a more specific permission and add a table to show the role + permissions.

I would also mention where in the navigation this can be updated :)

@TorstenDittmann TorstenDittmann added the documentation Improvements or additions to documentation label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants