Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroes page fixes #221

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Heroes page fixes #221

merged 12 commits into from
Oct 10, 2023

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Oct 9, 2023

What does this PR do?

  • Fixes navbar responsiveness (🐛 Bug Report: Docs navbar overflow appwrite#6856)
  • Improves navbar breakpoints and paddings
  • Fixes several design inconsistencies and missing details
  • Changes heroes images in scroll carousel
  • Fixes scroll carousel and adds progressive enhancement

Before and After

firefox_PCAoVXXb7z.mp4

@TGlide TGlide added the bug Something isn't working label Oct 9, 2023
@TGlide TGlide self-assigned this Oct 9, 2023
@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:23pm

@TGlide TGlide linked an issue Oct 10, 2023 that may be closed by this pull request
🐛 Bug Report: Docs navbar overflow appwrite/appwrite#6856
Closed
2 tasks
TorstenDittmann
TorstenDittmann reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2023-10-10 um 13 07 16
correct me if I'm wrong, but I think they should be all same height.

@TGlide
Copy link
Contributor Author

TGlide commented Oct 10, 2023

Bildschirmfoto 2023-10-10 um 13 07 16 correct me if I'm wrong, but I think they should be all same height.

Nope, this is following the design 😄
Figma_APmEOJdgEP

@TorstenDittmann TorstenDittmann merged commit b922021 into main Oct 10, 2023
4 checks passed
@TorstenDittmann TorstenDittmann deleted the change-heroes-imgs branch October 10, 2023 11:13
This was referenced Nov 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@ArmanNik ArmanNik Awaiting requested review from ArmanNik

Assignees

@TGlide TGlide

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Docs navbar overflow
2 participants
@TGlide @TorstenDittmann