Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model will conflict #1

Closed
jorenvh opened this issue Jul 7, 2015 · 5 comments
Closed

Model will conflict #1

jorenvh opened this issue Jul 7, 2015 · 5 comments

Comments

@jorenvh
Copy link

jorenvh commented Jul 7, 2015

Hi,

Just a tip, Laravel ships allready with a User model. Your model will eventullly conflict with the default one. Instead make a trait and update your docs to tell your users to make the user model use your trait.

Kind regards,
Joren

@sohelamin
Copy link
Member

Hi @jorenvh ,

Thanks for sharing your idea.
I just did as you said though I had a plan to do another thing with it for a another time but could not wait after you said.

Thanks
Sohel Amin

@jorenvh
Copy link
Author

jorenvh commented Jul 7, 2015

Glad I could help. Just thinking but first it was user model but why do you call it rolestrait? It's about uwers? Not that it's wrong but the name says somthing else the. It does.

@sohelamin
Copy link
Member

Thanks again @jorenvh
I think it is okay now.
And I'm going to close the issue.

@BrandonSurowiec
Copy link

I disagree with naming it UsersTrait. That tells me nothing about the trait when I read it on this line.

use Authenticatable, CanResetPassword, UserTrait;

Having the word roles in there was way better to describe what it did. I personally would name it like this:

use Authenticatable, CanResetPassword, HasRoles;

@sohelamin
Copy link
Member

Thanks @BrandonSurowiec for giving such a great idea.
I can understand what you point out about the naming.
I will do a better understandable naming on next release or update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants