Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to be automatically logged in upon verifying a their registration #40

Closed
gcbirzan opened this issue Mar 22, 2019 · 4 comments
Assignees

Comments

@gcbirzan
Copy link
Contributor

Currently, the user has to log in with his credentials, but this is pointless from a security point of view, since if he has access to the email he could reset the password.

There should be an option to automatically log in users after they verify their account.

@gcbirzan gcbirzan changed the title Allow logging users in upon verifying a user's registration Allow users to be automatically logged in upon verifying a their registration Mar 22, 2019
@apragacz
Copy link
Owner

Yes, you can do that, but these endpoints serve entirely different functionality: one is used for authentication, the other to restore the possibility to authenticate via password, as this is the method preferred currently by Django REST Registration.

I would agree that it could be useful not from the security standpoint, but from the functionality standpoint - the user does not need to re-enter the password when he/she confirms his/her e-mail after registration. So as opt-in option it would be certainly useful.

@gcbirzan
Copy link
Contributor Author

I didn't mean log in via an endpoint, I might misunderstand what you're trying to say there. My point was simply that verifying your registration should be enough to log you, just as resetting your password should.

I'll try to get some time this weekend to make a PR, but, most likely, it'll be some time Monday.

@apragacz apragacz assigned gcbirzan and unassigned apragacz Mar 22, 2019
gcbirzan added a commit to gcbirzan/django-rest-registration that referenced this issue Mar 26, 2019
gcbirzan added a commit to gcbirzan/django-rest-registration that referenced this issue Mar 26, 2019
@apragacz
Copy link
Owner

apragacz commented Apr 4, 2019

This feature was released in version 0.4.2.

@lock
Copy link

lock bot commented Apr 4, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants