Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it let's me register user without providing email address. #9

Closed
polinom opened this issue Feb 26, 2018 · 3 comments
Closed

it let's me register user without providing email address. #9

polinom opened this issue Feb 26, 2018 · 3 comments
Labels

Comments

@polinom
Copy link

polinom commented Feb 26, 2018

Here you have server where it's deployed and example request:

curl -X POST -d '{"username": "anyone", "password":"pass1234", "password_confirm":"pass1234"}' --header 'Content-Type: application/json' --header 'Accept: application/json' 'http://luken-qa.herokuapp.com/api/v1/accounts/register/'

my settings looks like this:

REST_REGISTRATION = {
        'REGISTER_VERIFICATION_ENABLED': True,
        "REGISTER_VERIFICATION_URL": "/verify-account/",

        'RESET_PASSWORD_VERIFICATION_URL': '/reset-password/',

        'REGISTER_EMAIL_VERIFICATION_ENABLED': True,
        'VERIFICATION_FROM_EMAIL': 'no-reply@example.com',
        "REGISTER_EMAIL_VERIFICATION_URL": "/verify-email/",
    }

Is this expected?

@polinom polinom changed the title It seems like it let's me register user without providing email address. it let's me register user without providing email address. Feb 26, 2018
@apragacz
Copy link
Owner

Thanks for reporting the bug! I was able to reproduce it with a test case. Working on fix right now...

apragacz added a commit that referenced this issue Feb 26, 2018
Register view was able to create user without email
with email verification enabled
@apragacz
Copy link
Owner

Looks that badly formulated if statement was the cause. Fix will be released in next version (0.3.7).

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants