switch to getopt_long() to fix linking against musl #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really need long options, but using getopt_long(), which is a GNU extension, relaxes the strict requirements that the strict POSIX compliant musl implementation of getopt() has. This behaviour stops parsing when it finds the first non-option argument, which is our action verb. So any parameter afterwards (like -v) is ignored. The glibc implementation of getopt() and all getopt_long() implementations shuffle argv and put option arguments first, so work as expected. This fixes operation on musl based systems, or when compiling a static binary with musl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need long options, but using getopt_long(), which is a GNU extension, relaxes the strict requirements that the strict POSIX compliant musl implementation of getopt() has. This behaviour stops parsing when it finds the first non-option argument, which is our action verb. So any parameter afterwards (like -v) is ignored.
The glibc implementation of getopt() and all getopt_long() implementations shuffle argv and put option arguments first, so work as expected.
This fixes operation on musl based systems, or when compiling a static binary with musl.