Skip to content

Commit

Permalink
Remove min version requirement for rocThrust
Browse files Browse the repository at this point in the history
It was introduced in ROCm 3.9 days. We now depend on Kokkos 4, which
requires ROCm 5.2.

This requiement also breaks compiling with ROCm 6, as rocThrust has
SameMajorVersion CMake compatibility mode instead of AnyNewerVersion,
and rocThrust coming with ROCm6 has version 3.x.
  • Loading branch information
aprokop committed Jan 26, 2024
1 parent 59ec655 commit 08476d7
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ add_dependencies(ArborX record_hash)
include(CMakeDependentOption)
cmake_dependent_option(ARBORX_ENABLE_ROCTHRUST "Enable rocThrust support" ON "Kokkos_ENABLE_HIP" OFF)
if(Kokkos_ENABLE_HIP AND ARBORX_ENABLE_ROCTHRUST)
# Require at least rocThrust-2.10.5 (that comes with ROCm 3.9) because
# rocPRIM dependency is not set properly in exported configuration for
# earlier versions
find_package(rocthrust 2.10.5 REQUIRED CONFIG)
find_package(rocthrust REQUIRED CONFIG)
target_link_libraries(ArborX INTERFACE roc::rocthrust)
endif()

Expand Down

0 comments on commit 08476d7

Please sign in to comment.