Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 support #1

Open
15 of 32 tasks
aprotyas opened this issue Jul 25, 2021 · 3 comments
Open
15 of 32 tasks

Add ROS 2 support #1

aprotyas opened this issue Jul 25, 2021 · 3 comments
Assignees
Labels
help wanted Extra attention is needed meta Higher-level issue used for task tracking

Comments

@aprotyas
Copy link
Owner

aprotyas commented Jul 25, 2021

This is a meta-ticket that I'll use to track progress for multiple smaller items. Notably:

@aprotyas
Copy link
Owner Author

aprotyas commented Jul 26, 2021

Notes:

  1. How should the parameter migration be done? Should TracIK really inherit from rclcpp::Node just for logging and some param services?
  2. Should TracIK be composable?
    i. This has to happen if I want to add support for a URDF XML subscription callback for TracIK.

@SteveNguyen
Copy link

Hi, I'm trying to get trac_ik_python compiling for ros2 but without success...
I made the changes from rospy to rclpy and the like, but I mostly have problems with ament and swig right now.
Do you have any clue on how to properly do that by any chance?

@aprotyas
Copy link
Owner Author

aprotyas commented Aug 8, 2021

Hi @SteveNguyen, unfortunately I haven't had the time to look at trac_ik_python yet. The "Move from rospy to rclpy" directive I've noted was only an initial hunch, and as you've seen already, there is probably a bunch more to do on top of that. I think you're on the right track because the rospy -> rclpy migration should be a big part of the port, but I'm not sure what to do after that.
TLDR: Give me a few hours to investigate, and I will report back here with any details I find. If you don't mind, can you open a draft PR for the ROS 2 port of trac_ik_python? It'd be easier to track progress that way.

Edit:
@SteveNguyen, can you give me some items to base this conversation off of? What swig problem are you having? Are you not able to use the swig functions in CMake? How about for ament? Linking errors? trac_ik_python needs a little more careful consideration while porting because, as you can tell, it's not just a regular Python package. I'll update the TODO list to reflect this. Please share any updates/thoughts you may have!

@aprotyas aprotyas added the meta Higher-level issue used for task tracking label Oct 18, 2021
@aprotyas aprotyas pinned this issue Oct 18, 2021
@aprotyas aprotyas added the help wanted Extra attention is needed label Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed meta Higher-level issue used for task tracking
Projects
None yet
Development

No branches or pull requests

2 participants