Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TISTUD-6674:Content Assist: Documentation link in Content assist opens invalid URL #282

Merged
merged 2 commits into from Nov 14, 2014

Conversation

sujmishra
Copy link

  1. Created a new extension of the com.aptana.editor.common.textHover in titanium UI to handle titanium
    specific URIs
  2. Handled titanium specific URIs in a subclass
  3. Added new test for the same.

@build
Copy link

build commented Nov 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://studio-jenkins.appcelerator.org//job/studio3-prs/106/Test PASSed.

<adapt type="org.eclipse.core.resources.IResource">
<and>
<not>
<test property="org.eclipse.core.resources.projectNature" value="com.appcelerator.titanium.mobile.nature" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we not make references to titanium project natures in studio3 codebase. Isn't there a mechanism for matching enablement expression based on how specific the variable used is (like command handlers do)? I recall Eclipse having infrastructure for that, so in this impl you'd just say always enabled and not reference any vars.

@build
Copy link

build commented Nov 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://studio-jenkins.appcelerator.org//job/studio3-prs/107/Test PASSed.

sujmishra pushed a commit that referenced this pull request Nov 14, 2014
TISTUD-6674:Content Assist: Documentation link in Content assist opens invalid URL
@sujmishra sujmishra merged commit d5dce77 into aptana:development Nov 14, 2014
@sgtcoolguy
Copy link
Contributor

Why was this merged?
Perhaps I should have been more explicit in my feedback. Beyond removing the enablement details from pointing at the titanium nature constants, the other main issue is that the extension point has no concept of the enablement expressions. You need to add the support for that into the consumer of the textHovers.

@sujmishra
Copy link
Author

We do have enablement expressions on the extension point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants