TISTUD-7521:iOS debugger connection refused with SDKs 3.5.0 and 3.5.1 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2180,39 +2175,42 @@ protected URI resolveSourceFile(String sourceFile) | |||
| try | |||
| { | |||
| URI uri = new URI(sourceFile); | |||
| String scheme = uri.getScheme(); | |||
| if (FILE.equals(scheme)) | |||
| if (!uri.isOpaque()) | |||
There was a problem hiding this comment.
Adding a guard might help to avoid NPE, however, they would still won't be able to debug the app. The underlying issue seems to be with getting the invalid path from the SDK debugger.
I realized that we log the debug protocol communication at <workspace>/.metadata/.plugins/com.appcelerator.titanium.ios.core/logs/iosdebugger.log and asked the customer for these logs.
|
Closing this PR as the we need to resolve the underlying issue with SDK debugger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't reproduce the issue, so I am going by backtracking.
By analyzing the error log we can understand that, NPE is coming bcoz of
URI.getPath()is returning null, this can only happen If URI string does not start path slash(/).If we look at the uri schemes (app, http, javascript) which we are expecting, Ideally all of them should always start with slash(/) after schema(ex:app:/) but somehow this was missing in certain cases and that leads to this issue.
A simple way to check this is,
if (!uri.isOpaque())
{
//http,app, javascript schema operations
}