Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DiskAttachment resource #155

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add DiskAttachment resource #155

merged 2 commits into from
Jul 19, 2023

Conversation

joshraker
Copy link
Member

@joshraker joshraker commented Jul 17, 2023 •
edited
Loading

@joshraker joshraker requested a review from almathew as a code owner July 17, 2023 18:22
@joshraker joshraker removed the request for review from almathew July 17, 2023 18:22
@joshraker
Copy link
Member Author

https://app.shortcut.com/aptible/story/15370/api-create-disk-service-attachment

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #15370: API - Create disk/service attachment.

madhuravius
madhuravius approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@madhuravius madhuravius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sanity checked the backend changes to this, i think it should be fine (though this layer is very honor-code-ey)

@madhuravius
Copy link
Contributor

don't forget if you do this you need to have a version release too (another follow up pr, which i can appr)

@joshraker joshraker merged commit ca4374c into master Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhuravius madhuravius madhuravius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joshraker @madhuravius