Dynamic Uno - Support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a helper `Operation#with_ssh_cmd` method that be called by clients to generate SSH a SSH connection (i.e. a certificate) and generate a suitable array of arguments to call SSH with. This was originally going to be in the CLI, but it makes sense to include it here so that other consumers can use these helpers. Namely, Primetime will be able to take advantage of this to access deployment logs via Dynamic Uno. See https://github.com/aptible/api.aptible.com/pull/448 for additional context.
|
@fancyremarker @blakepettersson, This was originally going to be a very minor PR, but I moved a bit of additional code into here to help fix the issue @fancyremarker brought up in https://github.com/aptible/api.aptible.com/pull/448. It's probably worth reviewing now (although all that code is pretty short). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @fancyremarker @blakepettersson