Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Deprovision databases #99

Merged
merged 2 commits into from
Feb 18, 2015
Merged

Conversation

mixonic
Copy link
Contributor

@mixonic mixonic commented Feb 18, 2015

@bantic please review and merge when appropriate.

Quickly nips off database deprovisioning from #51. There is definitely duplicated code between this an apps, but I'd like to defer getting eager about DRY until we are further along.

<div class="alert alert-warning fade in">
<a class="close" data-dismiss="alert">×</a>
<p>
There was a problem deprovisioning your database: {{error.responseJSON.message}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually settle on some sort of general strategy for displaying errors. Errors that don't have this shape (like a syntax error or some generic 500 response from the server) would end up looking funny.

@bantic
Copy link
Contributor

bantic commented Feb 18, 2015

awesome

bantic added a commit that referenced this pull request Feb 18, 2015
@bantic bantic merged commit 4a921ed into aptible:master Feb 18, 2015
@bantic bantic deleted the deprovision-databases branch February 18, 2015 15:55
@skylar-anderson skylar-anderson mentioned this pull request Feb 18, 2015
62 tasks
skylar-anderson pushed a commit to skylar-anderson/dashboard.aptible.com that referenced this pull request Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants