Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private dataset versions #13

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Support private dataset versions #13

merged 3 commits into from
Dec 30, 2022

Conversation

frafra
Copy link
Collaborator

@frafra frafra commented Dec 11, 2018

Fixes #12

@frafra
Copy link
Collaborator Author

frafra commented Feb 8, 2019

There is an issue at the moment: guests cannot access to the latest package using the URL without specifying the version:

File '/usr/lib/ckan/venv/src/ckan/ckan/controllers/package.py', line 401 in read
  context, {'id': resource['id']})
File '/usr/lib/ckan/venv/src/ckan/ckan/logic/__init__.py', line 464 in wrapped
  result = _action(context, data_dict, **kw)
File '/usr/lib/ckan/venv/src/ckan/ckan/logic/action/get.py', line 1139 in resource_view_list
  _check_access('resource_view_list', context, data_dict)
File '/usr/lib/ckan/venv/src/ckan/ckan/logic/__init__.py', line 306 in check_access
  raise NotAuthorized(msg)
NotAuthorized: User  not authorized to read resource f72292e5-04e1-41ff-92c4-64aa9dca6b25

@frafra frafra marked this pull request as draft March 2, 2022 16:37
@frafra frafra marked this pull request as ready for review December 30, 2022 13:37
@frafra
Copy link
Collaborator Author

frafra commented Dec 30, 2022

I have been using this patch in production for quite a while now, without any major issue.

@frafra frafra merged commit bdec239 into aptivate:master Dec 30, 2022
@frafra
Copy link
Collaborator Author

frafra commented Dec 30, 2022

Merged and squashed in b753465.
Let me know if there is anything else that should be changed/improved :)

@frafra frafra deleted the private-datasets branch December 30, 2022 13:49
@martinburchell
Copy link
Contributor

@frafra really happy for you to merge anything you find useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versions ignored if private
2 participants