Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing Travis CI build #2

Merged
merged 3 commits into from
Sep 12, 2017
Merged

Fix failing Travis CI build #2

merged 3 commits into from
Sep 12, 2017

Conversation

decentral1se
Copy link
Member

@decentral1se decentral1se commented Sep 11, 2017 •
edited
Loading

It's a weird error, so I'll need to play around to find out why it's failing.

It appears there are two issues:

  1. A failling package install due to missing version
  2. Installing a new postgres (well, old, 9.1) conflicts with an existing postgres 9.2

TODO:

  • Bump PGVERSION up to 9.3 (match Map Action version)
  • Get postgres to successfully start (after version setup)

Closes #3.

@decentral1se decentral1se mentioned this pull request Sep 11, 2017
Closed
@decentral1se
Don't be explicit in the version for the package.
727728d 
This will avoid errors when pinned versions are not
discoverable from the Travis PPAs configured.
@decentral1se
Bump up to PostgreSQL v3 and use Travis's service.
acb5e88 
We will match Map Actions postgres version and won't have to handle
errors when postgres fails to boot up (as has been seen with lesser
versions).
@decentral1se decentral1se changed the title WIP: Fix failing Travis CI build Fix failing Travis CI build Sep 11, 2017
martinburchell
martinburchell approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@martinburchell martinburchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@decentral1se decentral1se mentioned this pull request Sep 11, 2017
Closed
@decentral1se
Copy link
Member Author

Am I OK to merge this or?

@martinburchell martinburchell merged commit eb3d3c9 into aptivate:master Sep 12, 2017
@decentral1se decentral1se deleted the fixup-travis-ci branch September 12, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinburchell martinburchell martinburchell approved these changes

@tomd-aptivate tomd-aptivate Awaiting requested review from tomd-aptivate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@decentral1se @martinburchell